Skip to content

Commit

Permalink
gitweb: Pass esc_html_hl_regions() options to esc_html()
Browse files Browse the repository at this point in the history
With this change, esc_html_hl_regions() accepts options and passes them
down to esc_html().  This may be needed if a caller wants to pass
-nbsp=>1 to esc_html().

The idea and implementation example of this change was described in
337da8d (gitweb: Introduce esc_html_match_hl and esc_html_hl_regions,
2012-02-27).  While other suggestions may be more useful in some cases,
there is no need to implement them at the moment.  The
esc_html_hl_regions() interface may be changed later if it's needed.

Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
  • Loading branch information
mkiedrowicz authored and jnareb committed Mar 29, 2012
1 parent 57ab319 commit 1a60532
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions gitweb/gitweb.perl
Expand Up @@ -1732,7 +1732,9 @@ sub chop_and_escape_str {
# '<span class="mark">foo</span>bar'
sub esc_html_hl_regions {
my ($str, $css_class, @sel) = @_;
return esc_html($str) unless @sel;
my %opts = grep { ref($_) ne 'ARRAY' } @sel;
@sel = grep { ref($_) eq 'ARRAY' } @sel;
return esc_html($str, %opts) unless @sel;

my $out = '';
my $pos = 0;
Expand All @@ -1741,14 +1743,14 @@ sub esc_html_hl_regions {
# Don't craete empty <span> elements.
next if $s->[1] <= $s->[0];

$out .= esc_html(substr($str, $pos, $s->[0] - $pos))
$out .= esc_html(substr($str, $pos, $s->[0] - $pos), %opts)
if ($s->[0] - $pos > 0);
$out .= $cgi->span({-class => $css_class},
esc_html(substr($str, $s->[0], $s->[1] - $s->[0])));
esc_html(substr($str, $s->[0], $s->[1] - $s->[0]), %opts));

$pos = $s->[1];
}
$out .= esc_html(substr($str, $pos))
$out .= esc_html(substr($str, $pos), %opts)
if ($pos < length($str));

return $out;
Expand Down

0 comments on commit 1a60532

Please sign in to comment.