Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for trying Chronos out! It looks like the predictions from Chronos are misaligned when you compute the metrics. This PR fixes this issue. Furthermore, there were multiple inefficiencies in the inference loop for Chronos:
Here are the final numbers after these fixes:
In case you're wondering what was the bug in the previous version: the index in
forecast_df
was incorrect after sorting. You can fix the previous version by simply changing:to
Based on these results, I kindly ask you to modify your code and blog post. Furthermore, I would also request you to post an update on your social media profiles. Please let me know if you need any help from our side running Chronos! Thank you again!