handle method definitions with constants #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
requested changes
Aug 7, 2023
Comment on lines
+203
to
+204
| @modules << existing | ||
| @namespace << existing |
There was a problem hiding this comment.
I think we shouldn't add it to the @modules or @namesapce since we are not going to traverse it's children, so we don't need to set setup it up to be part of the namespace, since we would also need to pop them again
| elsif existing = @analyzer.classes.detect { |name| name.qualified_name == target } | ||
| return prev if @classes.find { |klass| klass.qualified_name == existing.qualified_name } | ||
|
|
||
| @classes << existing |
| # rubocop:disable Lint/AssignmentInCondition | ||
| def inferred_context_for(target) | ||
| if existing = @analyzer.modules.detect { |name| name.qualified_name == target } | ||
| return prev if @modules.find { |mod| mod.qualified_name == existing.qualified_name } |
|
I'm afraid this one needs quite some rework after #41. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20
Not in love with
#inferred_context_forbut it seems to work.