-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Frameworks Page #42
Conversation
Should the framework model be ordered alphabetically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @pkayokay, this looks great!
Should the framework model be ordered alphabetically?
I think that would make sense, yes!
I was also wondering if we might be able to upstream some of those framework icons directly to the iconfont itself. But for now to keep it simple, we can keep it like this.
Would you mind updating the icons in the app/views/application/home/_integrations.html.erb
file as well. That would be great, thank you!
Otherwise this looks good to me!
Would we want all the frameworks listed on the integrations partials? or just update the existing ones? (only the Bridgetown icon needs to be updated) |
Oh right, then let's just update the Bridgetown one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you so much for this @pkayokay!
Oh man @pkayokay you are ahead of me, but you beat me to it 👍🏼 😄 |
Improves the overall look of the frameworks page, also adds a logo and descriptions to each item. Closes #33
Before
After
Desktop
Smaller desktop
Mobile