Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Frameworks Page #42

Merged
merged 34 commits into from
Oct 18, 2023
Merged

Conversation

pkayokay
Copy link
Contributor

@pkayokay pkayokay commented Oct 17, 2023

Improves the overall look of the frameworks page, also adds a logo and descriptions to each item. Closes #33

Before

image

After

Desktop

desktop

Smaller desktop

between

Mobile

mobile

@pkayokay
Copy link
Contributor Author

Should the framework model be ordered alphabetically?

Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @pkayokay, this looks great!

Should the framework model be ordered alphabetically?

I think that would make sense, yes!

I was also wondering if we might be able to upstream some of those framework icons directly to the iconfont itself. But for now to keep it simple, we can keep it like this.

Would you mind updating the icons in the app/views/application/home/_integrations.html.erb file as well. That would be great, thank you!

Otherwise this looks good to me!

@pkayokay
Copy link
Contributor Author

pkayokay commented Oct 18, 2023

Would we want all the frameworks listed on the integrations partials? or just update the existing ones? (only the Bridgetown icon needs to be updated)

@marcoroth
Copy link
Owner

Oh right, then let's just update the Bridgetown one.

@pkayokay
Copy link
Contributor Author

image

Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you so much for this @pkayokay!

@marcoroth marcoroth merged commit 6d4309b into marcoroth:main Oct 18, 2023
1 check passed
@AhmedNadar
Copy link

Oh man @pkayokay you are ahead of me, but you beat me to it 👍🏼 😄
I'm working on it and my version is so close to your. Well done Paul, looks awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Frameworks page
3 participants