Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel support #31

Merged
merged 9 commits into from
Oct 21, 2023
Merged

Laravel support #31

merged 9 commits into from
Oct 21, 2023

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Oct 19, 2023

Added

  • Adds Blade as a supported language
  • Make the file watcher based on the controllers path

server/src/settings.ts Outdated Show resolved Hide resolved
client/src/client.ts Outdated Show resolved Hide resolved
@marcoroth
Copy link
Owner

@tonysm I just merged #45 and marcoroth/stimulus-parser#16 which should simplify the implementation of this pull-request 🙌🏼

server/src/server.ts Outdated Show resolved Hide resolved
@tonysm
Copy link
Contributor Author

tonysm commented Oct 21, 2023

It's currently only suggesting the data-* attributes in blade files (files ending in .blade.php) when I switch the language to "HTML" and then back to "Blade". I'm not sure why this is happening. I tried moving HTML to the bottom of the document selector list, thinking it could be the order or something, but it's still not working out-of-the-box... 🤔

@marcoroth
Copy link
Owner

Looking at the Tailwind Intellisense plugin they have something to attach their behaviour to existing filetypes:

https://github.com/tailwindlabs/tailwindcss-intellisense/blob/3cd88c8abdf99bb77296265251bf938295481c9b/packages/vscode-tailwindcss/README.md#tailwindcssincludelanguages

Along with a bunch of built-in languages here:

https://github.com/tailwindlabs/tailwindcss-intellisense/blob/3cd88c8abdf99bb77296265251bf938295481c9b/packages/tailwindcss-language-service/src/util/languages.ts#L3-L10

Maybe we need something similar in Stimulus LSP.

@marcoroth
Copy link
Owner

And maybe we also want to look into configuring files.associations.

Though, I'm not sure if this is something we can control or if this is something the user has to configure in their editor.

@tonysm tonysm marked this pull request as ready for review October 21, 2023 17:52
@tonysm tonysm requested a review from marcoroth October 21, 2023 17:54
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, @tonysm!

@marcoroth marcoroth merged commit e6be880 into marcoroth:main Oct 21, 2023
1 check passed
@wizzymore wizzymore mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants