Add loc getters to Value Definition
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nachiket87
force-pushed
the
add-getters-to-value-definition
branch
from
5386352
to
b698054
Compare
nachiket87
commented
Apr 16, 2024
nachiket87
force-pushed
the
add-getters-to-value-definition
branch
from
2b2814b
to
b4ef719
Compare
|
Thanks for opening this pull request, @nachiket87! For the |
nachiket87
force-pushed
the
add-getters-to-value-definition
branch
from
432377e
to
414d12f
Compare
@marcoroth hey! I've used the kind value in the last commit. |
|
@nachiket87 awesome thank you! Is this ready to go from your perspective? |
marcoroth
changed the title
loc getters to Value Definition
nachiket87
commented
Apr 23, 2024
nachiket87
commented
Apr 24, 2024
marcoroth
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @marcoroth,
Based on our discussion, I'm trying to add the various Loc's as getters on ValueDefinition. Here is a draft for you to see what I'm doing. The
TypeLocgetter seems to be challenging as thethis.nodevalue of the valuedefinition can have various different syntaxes and we would have to filter throughObjectExpressiontype orLiteraltypes.