Parse controllers with class fields without value correctly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djfpaagman
force-pushed
the
public_class_fields
branch
from
b13572a
to
19dd9b4
Compare
|
I've changed the test a bit (and fixed the syntax error) to just test for no errors being set. Also added the example class fields so all possibles syntaxes are covered. |
marcoroth
approved these changes
Nov 20, 2023
Comment on lines
+157
to
+158
| instanceField | ||
| instanceFieldWithInitializer = "instance field" |
There was a problem hiding this comment.
I'm surprised that this is even valid syntax 🤯
Thanks for catching this!
|
Thanks @djfpaagman! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at fixing the bug I reported in #20.
Let me know what you think! I've added an extra test, doubted to extend the first test to have the class fields, but then it's not clear why they're there.