set_turbo_frame_src operation
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Oct 30, 2022
There was a problem hiding this comment.
Hey @leon-vogt, thanks for opening this pull request! Good catch!
Regarding the attribute name: Turbo Stream Actions usually make use of the target attribute for targeting elements. Since we are interacting with <turbo-frame> elements which have regular id attributes we can also rely on the built-in target attribute for that.
This also has the benefit that we can make use of the built-in this.targetElements getter on the client-side if we write the stream element like this:
<turbo-stream action="set_turbo_frame_src" target="frame_one" src="/page2.html"></turbo-stream>
leonvogt
force-pushed
the
add-set_turbo_frame_src-operation
branch
from
fbf8086
to
95634ad
Compare
|
@marcoroth thanks for your reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the current implementation of
set_turbo_frame_srcfor the new operation in: marcoroth/turbo_power#6