-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement turbo_frame_reload
and turbo_frame_set_src
actions
#10
Conversation
reload_turbo_frame
and set_turbo_frame_src
actions
Hey @minimul, thanks for taking this one on, I think this looks good implementation-wise! I was thinking about the action names and I'm not quite sure if I really like them. Somehow I feel like the Do you have a strong opinion on that? From a readability/reading-flow point of view I think |
Yeah, the naming actually tripped me up a bit during implementation. I'd somewhat strongly vote for going with prefixes. Let me know and I'll make what changes are needed. |
Alright, let's go with the prefixed names then! Thank you! |
84c54a4
to
7dc9f87
Compare
OK, changes are in. |
reload_turbo_frame
and set_turbo_frame_src
actionsturbo_frame_reload
and turbo_frame_set_src
actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @minimul!
Closes #5 and Closes #6