Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for options in scroll_into_view action #129

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

woto
Copy link
Contributor

@woto woto commented Dec 31, 2023

Hi, I'm not too much JS as well as in TS. So you may fix my PR if you wish, at least I wanted to show my necessities and ways to improve library. And it works for me ;)

@woto
Copy link
Contributor Author

woto commented Jan 6, 2024

@marcoroth ping :)

@marcoroth marcoroth changed the title Add support scrollIntoView options in #scroll_into_view Add support for options in scroll_into_view action Jan 7, 2024
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @woto this looks good to me, I added some tests 👍🏼

@marcoroth marcoroth merged commit 23a58fb into marcoroth:main Jan 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants