Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typecasting in set_property action #27

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Fix typecasting in set_property action #27

merged 1 commit into from
Dec 31, 2022

Conversation

minimul
Copy link
Contributor

@minimul minimul commented Dec 21, 2022

No description provided.

marcoroth
marcoroth reviewed Dec 21, 2022
View reviewed changes
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @minimul! I left some comments

src/actions/attributes.ts Outdated Show resolved Hide resolved
src/actions/attributes.ts Outdated Show resolved Hide resolved
@marcoroth marcoroth changed the title Fix set_property method Fix typecasting in set_property action Dec 29, 2022
@marcoroth marcoroth added the bug Something isn't working label Dec 29, 2022
marcoroth
marcoroth approved these changes Dec 31, 2022
View reviewed changes
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @minimul!

@marcoroth marcoroth merged commit ba003a1 into marcoroth:main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minimul @marcoroth