implement set_cookie_item action
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Hey @lxxxvi, thank you very much for opening this pull request! 馃帀
I left some comments and ideas for refactoring, but I think that the functionality itself is awesome as-is!
It seems like that the project itself isn't building because some type annotations are missing. If you run yarn watch in the terminal it should also give you the same errors the GitHub action added as annotations.
Let me know if you are stuck, I'm more than happy to help you getting them resolved 馃檶馃徏
lxxxvi
force-pushed
the
implement-set-cookie-item
branch
from
6a1f6ba
to
1429233
Compare
|
@marcoroth Thanks for your review, I appreciate it! I applied the suggested changes, you may have second look now 馃槈 |
marcoroth
added a commit
to marcoroth/turbo_power-rails
that referenced
this pull request
Feb 12, 2023
This pull request updates the stream helper for the `set_cookie_item` action. It makes the positional arguments optional in order to just allow to specify them as keyword arguments. this action was implemented in marcoroth/turbo_power#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This PR addresses #1 (wohoo).
I may have taken a "overcomplicated" approach to build the Cookie String. I appreciate your feedback, letme know what/if I can improve anything, I'm eager to learn! Thank you.