Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup invisibles #34

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Cleanup invisibles #34

merged 3 commits into from
Jan 24, 2023

Conversation

lxxxvi
Copy link
Sponsor Contributor

@lxxxvi lxxxvi commented Jan 24, 2023

Hi 馃憢

This PR is a simple cleanup task:

  • Replaces non-breaking spaces with regular ones
  • Removes empty lines
  • Removes trailing white spaces

Also, I was wondering what part prettier plays in the project? For example: Many files of the project use single quotes although the configuration in .prettierrc.json says

"singleQuote": false,

(Short: My editor keeps replacing the quotes automatically... 馃槃)

Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this pull request @lxxxvi!

I love how consistently it used non-breaking spaces throughout almost occurrences of executeStream 馃檭

I think part of the problem is that prettier is only setup to lint TypeScript .ts files and not the JavaScript .js within the test/ directory.

Maybe we could also change that? Otherwise I'm also happy to merge this as-is.

@marcoroth
Copy link
Owner

Or I should say eslint (which uses prettier as a plugin):

"lint": "eslint . --ext .ts --ignore-pattern *.d.ts",

@lxxxvi
Copy link
Sponsor Contributor Author

lxxxvi commented Jan 24, 2023

@marcoroth I think something is not right with the eslint setup either, but I have no experience there. Should/could we have look at it together?

@marcoroth
Copy link
Owner

@lxxxvi let's do that in a separate PR so we can merge this one, thank you! 馃帀

@marcoroth marcoroth merged commit 570e953 into marcoroth:main Jan 24, 2023
marcoroth added a commit that referenced this pull request Jan 24, 2023
This pull request changes the eslint config so that the rules are also
being applied and enforced on all `*.js` files as noted by @lxxxvi in
#34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants