Add unit tests and exclude POJO from code coverage

marcosbarbero · Oct 12, 2019 · 60acb4d · 60acb4d
1 parent 2398f3e
commit 60acb4d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/pom.xml b/pom.xml
@@ -175,6 +175,9 @@
                         <exclude>**/test/**</exclude>
                         <exclude>**/tests/**</exclude>
                         <exclude>**/*Constants.*</exclude>
+                        <exclude>
+                            com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/config/properties/RateLimitProperties.*
+                        </exclude>
                     </excludes>
                 </configuration>
                 <executions>

diff --git a/.../com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/RateLimitAutoConfigurationTest.java b/.../com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/RateLimitAutoConfigurationTest.java
@@ -4,6 +4,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.hazelcast.core.IMap;
 import com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.RateLimitKeyGenerator;
+import com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.RateLimitUtils;
 import com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.RateLimiter;
 import com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties;
 import com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties.Policy;
@@ -20,7 +21,6 @@
 import org.apache.ignite.IgniteCache;
 import org.infinispan.functional.FunctionalMap.ReadWriteMap;
 import org.junit.Test;
-import org.mockito.Mockito;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.boot.autoconfigure.AutoConfigurations;
 import org.springframework.boot.context.annotation.UserConfigurations;
@@ -35,6 +35,7 @@
 
 import static com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties.PREFIX;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Marcos Barbero
@@ -52,6 +53,12 @@ public void testStringToMatchTypeConverter() {
                 .run((context) -> assertThat(context).hasSingleBean(StringToMatchTypeConverter.class));
     }
 
+    @Test
+    public void testRateLimitUtils() {
+        contextRunner.withPropertyValues(PREFIX + ".repository=BUCKET4J_JCACHE")
+                .run((context) -> assertThat(context).hasSingleBean(RateLimitUtils.class));
+    }
+
     @Test
     public void testZuulFilters() {
         contextRunner.withPropertyValues(PREFIX + ".repository=BUCKET4J_JCACHE")
@@ -132,43 +139,44 @@ public static class Conf {
 
         @Bean
         public RouteLocator routeLocator() {
-            return Mockito.mock(RouteLocator.class);
+            return mock(RouteLocator.class);
         }
 
         @Bean
         public ConsulClient consulClient() {
-            return Mockito.mock(ConsulClient.class);
+            return mock(ConsulClient.class);
         }
 
         @Bean
         public ObjectMapper objectMapper() {
-            return Mockito.mock(ObjectMapper.class);
+            return mock(ObjectMapper.class);
         }
 
         @Bean
         public RedisConnectionFactory redisConnectionFactory() {
-            return Mockito.mock(RedisConnectionFactory.class);
+            return mock(RedisConnectionFactory.class);
         }
 
         @Bean
         @Qualifier("RateLimit")
         @SuppressWarnings("unchecked")
         public IMap<String, GridBucketState> hazelcastMap() {
-            return Mockito.mock(IMap.class);
+            return mock(IMap.class);
         }
 
         @Bean
         @Qualifier("RateLimit")
         @SuppressWarnings("unchecked")
         public IgniteCache<String, GridBucketState> igniteCache() {
-            return Mockito.mock(IgniteCache.class);
+            return mock(IgniteCache.class);
         }
 
         @Bean
         @Qualifier("RateLimit")
         @SuppressWarnings("unchecked")
         public ReadWriteMap<String, GridBucketState> infinispanMap() {
-            return Mockito.mock(ReadWriteMap.class);
+            return mock(ReadWriteMap.class);
         }
+
     }
 }