-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement token-bucket algorithm #55
Comments
I think it is a good direction, not sure about this implementation. |
Good to know. |
Saw them, I think the main issue is the configuration required because it is not zuul specific. |
Don't you think it would be better to entirely move the ratelimit algorithm to a |
Well, since buckets doesn't work natively with time limitation, the filters are still required. |
Actually that's the main idea, I'm not planning to remove any supported backend just to move the logic towards a bucked based algorithm. |
not sure I understood, maybe we are saying the same. |
I think we are actually saying the same thing :D |
@lchayoun I'm thinking about to change our main implementation to use a
token-bucket
instead.Here's a link to take a look https://github.com/bbeck/token-bucket.
WDYT?
The text was updated successfully, but these errors were encountered: