Fix 165 for 1.7.x #179
Merged
Fix 165 for 1.7.x #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be enabled or disabled for every policy
…ect input, it will just return false.
Merged
|
@marcosbarbero, have you gotten a chance to look at this? |
|
Hi @andrew-holman, unfortunately, I still did not have time to look into it. I'll do my best to get it up and running tomorrow |
marcosbarbero
approved these changes
Jul 21, 2019
|
@andrew-holman could you follow up? The code coverage seems to have dropped https://coveralls.io/builds/24704870 |
|
@marcosbarbero of course, I'll get on that right away. Did the code coverage only drop in the 1.7.x branch or was it an issue with the master branch as well? |
|
It dropped on master as well but I remember I'd it fixed before releasing. |
andrew-holman
added a commit
to andrew-holman/spring-cloud-zuul-ratelimit
that referenced
this pull request
Jul 23, 2019
Fix 165 for 1.7.x (marcosbarbero#179)
|
Okay, this should be resolved in #183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165 for branch 1.7.x
Changes proposed in this pull request: