Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added quota rate limit #19

Merged
merged 7 commits into from
Sep 19, 2017
Merged

added quota rate limit #19

merged 7 commits into from
Sep 19, 2017

Conversation

lchayoun
Copy link
Collaborator

@lchayoun lchayoun commented Sep 15, 2017 •
edited by marcosbarbero

WIP #18

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.6%) to 78.723% when pulling abf3054 on lchayoun:Feature/QuotaRateLimit into ffc9b4d on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.6%) to 78.723% when pulling abf3054 on lchayoun:Feature/QuotaRateLimit into ffc9b4d on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.2%) to 79.144% when pulling be16c19 on lchayoun:Feature/QuotaRateLimit into ffc9b4d on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.2%) to 79.144% when pulling be16c19 on lchayoun:Feature/QuotaRateLimit into ffc9b4d on marcosbarbero:master.

@lchayoun
Copy link
Collaborator Author

@marcosbarbero coveralls didn't run on the last commit, how can we make it run?
I think this pull is ready for review.

@marcosbarbero
Copy link
Owner

I'll run it

marcosbarbero
marcosbarbero reviewed Sep 18, 2017
View reviewed changes
...in/java/com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/RateLimitAutoConfiguration.java Outdated
final RateLimitProperties rateLimitProperties,
final RouteLocator routeLocator,
final RateLimitKeyGenerator rateLimitKeyGenerator) {
UrlPathHelper urlPathHelper = new UrlPathHelper();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As UrlPathHelper is being used in pre and post filter bean maybe it will be better to create this object at class level, WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@marcosbarbero marcosbarbero merged commit 1d1dbe2 into marcosbarbero:master Sep 19, 2017
@lchayoun lchayoun deleted the Feature/QuotaRateLimit branch September 19, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosbarbero marcosbarbero marcosbarbero left review comments

Assignees

@marcosbarbero marcosbarbero

@lchayoun lchayoun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lchayoun @coveralls @marcosbarbero