Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quota tests #21

Merged
merged 5 commits into from
Sep 21, 2017
Merged

Adding quota tests #21

merged 5 commits into from
Sep 21, 2017

Conversation

lchayoun
Copy link
Collaborator

WIP

@coveralls
Copy link

Coverage Status

Coverage increased (+2.8%) to 87.5% when pulling 107fe7d on lchayoun:QuotaTests into a766903 on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 89.063% when pulling a61ec84 on lchayoun:QuotaTests into a766903 on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.0%) to 90.625% when pulling 7a7a773 on lchayoun:QuotaTests into a766903 on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.7%) to 95.313% when pulling c8fd4d8 on lchayoun:QuotaTests into a766903 on marcosbarbero:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.7%) to 95.313% when pulling 890e613 on lchayoun:QuotaTests into a766903 on marcosbarbero:master.

@lchayoun
Copy link
Collaborator Author

@marcosbarbero WDYT? change the exclusion patterns of coverage, added missing tests #18

@@ -39,4 +50,23 @@ public void setUp() {
ObjectMapper objectMapper = new ObjectMapper();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this objectMapper is no longer needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed for the rest of the tests (from the base class)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I'll merge it then.

@marcosbarbero marcosbarbero merged commit 4116811 into marcosbarbero:master Sep 21, 2017
@lchayoun lchayoun deleted the QuotaTests branch September 21, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants