Changing SizesWindow's rootViewController after initial setup doesn't remove the old child view

[frankdilo]

Expected Behavior

Only ViewB should be on screen.

Actual Behavior

ViewA is on screen on top of ViewB.

Steps to Reproduce the Problem

1. Set SizesWindow as app window in AppDelegate
2. Set the root view controller of the window to ViewControllerA
3. Later on in the app, change the root view controller of the window to ViewControllerB
4. Observe that both ViewA and ViewB are on screen

[frankdilo]

I already spotted the problem and can provide a PR with a fix:

open class SizesWindow: UIWindow {
    
    public let sizesViewController = SizesViewController()
    
    override open var rootViewController: UIViewController? {
        get {
            return sizesViewController.containedController
        }
        set {
            guard let root = newValue, !root.isKind(of: SizesViewController.self) else {
                return
            }
            super.rootViewController = sizesViewController
            sizesViewController.contain(viewController: root)
        }
    }
}

In the setter, before adding another child view controller we should remove the existing one if it's there. I can submit a PR.

[marcosgriselli]

Exactly. I think we need to modify the contain(viewController: _) method to handle this. I'd really appreciate a PR :).

[frankdilo]

Done! 🙌

[marcosgriselli]

Closed in #20