Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save a screenshot of the current layout #22

Closed
marcosgriselli opened this issue Oct 21, 2018 · 9 comments
Closed

Save a screenshot of the current layout #22

marcosgriselli opened this issue Oct 21, 2018 · 9 comments
Assignees
Projects

Comments

@marcosgriselli
Copy link
Owner

We could add a 'take screenshot' button that generates a UIImage from the containedView and displays the share sheet so we can save/share the image of the current layout in full size.

Ideally, we can let users select if they want to place a label with the current device/orientation/font size on the generated image though this is not a priority.

Current situation when taking a screenshot when using Sizes on an iPad testing small phones layouts:

@marcosgriselli marcosgriselli added this to To do in Sizes via automation Oct 21, 2018
@gtrunso
Copy link
Collaborator

gtrunso commented Oct 21, 2018

I'm taking care of it

@marcosgriselli
Copy link
Owner Author

Great @gtrunso, I'll assign you the issue 🙂

@csknns
Copy link

csknns commented Oct 22, 2018

I have implemented this! Did not see @gtrunso comment, sorry.(Github has technical issues and did not let yesterday to fork the repo to submit a pull request)
Would you like a pull request to review it, or should I scrap it?

Repository owner deleted a comment from csknns Oct 22, 2018
@marcosgriselli
Copy link
Owner Author

Hey @csknns thanks for working on this! @gtrunso wasn't able to send the PR yesterday due to the GitHub issues. I think this is a great opportunity for both of you to work together since this functionality will require a bit of extra work to be perfect. Also, I recommend we wait until the issues with GitHub are solved since is messing up with the workflows.

@marcosgriselli
Copy link
Owner Author

I'd avoid pushing new branches or sending PRs. @csknns I just got an email from a PR of yours but it's not showing up on GitHub for me so let's wait until GitHub is working properly to work on this.

@csknns
Copy link

csknns commented Oct 22, 2018

@marcosgriselli I agree, I will close the PR for now and wait until Github reports everything is back to normal.
It will be a great to collaborate with @gtrunso on this issue!

@jbuchman
Copy link

Please make sure that the screenshots are at the native resolution of the view as opposed to the resolution of the device. I had implemented something similar for my use case, but found that if I screenshot the SizesWindow or SizesViewController's views I ended up with a screenshot at the device's resolution instead of the resolution of the simulated size...

@marcosgriselli
Copy link
Owner Author

Yeah, we'll be tweaking this to make it perfect.

@marcosgriselli
Copy link
Owner Author

Added functionality on #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sizes
  
Done
Development

No branches or pull requests

4 participants