-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save a screenshot of the current layout #22
Comments
I'm taking care of it |
Great @gtrunso, I'll assign you the issue 🙂 |
I have implemented this! Did not see @gtrunso comment, sorry.(Github has technical issues and did not let yesterday to fork the repo to submit a pull request) |
Hey @csknns thanks for working on this! @gtrunso wasn't able to send the PR yesterday due to the GitHub issues. I think this is a great opportunity for both of you to work together since this functionality will require a bit of extra work to be perfect. Also, I recommend we wait until the issues with GitHub are solved since is messing up with the workflows. |
I'd avoid pushing new branches or sending PRs. @csknns I just got an email from a PR of yours but it's not showing up on GitHub for me so let's wait until GitHub is working properly to work on this. |
@marcosgriselli I agree, I will close the PR for now and wait until Github reports everything is back to normal. |
Please make sure that the screenshots are at the native resolution of the view as opposed to the resolution of the device. I had implemented something similar for my use case, but found that if I screenshot the SizesWindow or SizesViewController's views I ended up with a screenshot at the device's resolution instead of the resolution of the simulated size... |
Yeah, we'll be tweaking this to make it perfect. |
Added functionality on #29 |
We could add a 'take screenshot' button that generates a
UIImage
from thecontainedView
and displays the share sheet so we can save/share the image of the current layout in full size.Ideally, we can let users select if they want to place a label with the current device/orientation/font size on the generated image though this is not a priority.
Current situation when taking a screenshot when using Sizes on an iPad testing small phones layouts:
![](https://user-images.githubusercontent.com/14804033/47268911-2ec97780-d52d-11e8-9f0a-9995cc6d2158.png)
The text was updated successfully, but these errors were encountered: