Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry #40

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Add telemetry #40

merged 14 commits into from
Nov 6, 2023

Conversation

marcoshuck
Copy link
Owner

@marcoshuck marcoshuck commented Nov 2, 2023

This PR adds support for telemetry to the gRPC server, as well as defining tracing for gorm and recording events on the create task method

Fix #17
Fix #16
Fix #12
Fix #11

Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
@marcoshuck marcoshuck self-assigned this Nov 2, 2023
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
cmd/gateway/main.go Outdated Show resolved Hide resolved
Address different issues in code

Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
@marcoshuck
Copy link
Owner Author

Instrumentation between client and server isn't working, the span is created, and the latency is measured correctly, but no correlation can be made between an incoming trace from the gateway to the spans created in the server. Left as future work.

@marcoshuck marcoshuck merged commit 40e82a4 into main Nov 6, 2023
3 of 4 checks passed
@marcoshuck marcoshuck deleted the feature/telemetry branch November 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a Grafana dashboard Add metrics with Prometheus Create docker compose Add tracing with Jaeger
1 participant