-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry #40
Merged
Merged
Add telemetry #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
marcoshuck
commented
Nov 3, 2023
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
marcoshuck
commented
Nov 4, 2023
marcoshuck
commented
Nov 4, 2023
Address different issues in code Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Instrumentation between client and server isn't working, the span is created, and the latency is measured correctly, but no correlation can be made between an incoming trace from the gateway to the spans created in the server. Left as future work. |
Signed-off-by: Marcos Huck <marcoshuck@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for telemetry to the gRPC server, as well as defining tracing for gorm and recording events on the create task method
Fix #17
Fix #16
Fix #12
Fix #11