feat: Bump Go version to 1.20 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbevc1
commented
Jul 21, 2023
•
mbevc1
commented
- Bump Go to 1.20
- Update some dependencies
marcosnils
reviewed
Jul 21, 2023
.github/workflows/build.yml
Outdated
| @@ -23,6 +23,6 @@ jobs: | |||
| - name: Install Go | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.19 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
this needs to be between '' I think because YAML reasons.
There was a problem hiding this comment.
Happy to put in in quotes, but never had issues using without :)
There was a problem hiding this comment.
did you go back to go 1.2? 😅
There was a problem hiding this comment.
Ah, I see now what you meant 😄 Fixing... 🛠️
marcosnils
approved these changes
Jul 21, 2023
|
Cheers @marcosnils . It's probably worth cutting a fresh release build with 1.20? 🤔 |
|
there's no rush since there's no functionality change withing the releases? |
|
Yeah, not urgent but just build with newer Golang. |
|
np. I was planning to fix some bugs the following days so I'll probably make the release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.