Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type annotations. #109

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

pawelrubin
Copy link
Contributor

@pawelrubin pawelrubin commented Jun 29, 2021

This PR introduces some improvements of type annotations in the AvroModel class.

Most importantly, deserialize and fake methods, which now have correct and generic return types.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #109 (56e375f) into master (f17d4b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   99.56%   99.57%           
=======================================
  Files           7        7           
  Lines         694      698    +4     
  Branches      110      110           
=======================================
+ Hits          691      695    +4     
  Misses          1        1           
  Partials        2        2           
Impacted Files Coverage Δ
dataclasses_avroschema/types.py 100.00% <ø> (ø)
dataclasses_avroschema/fields.py 99.52% <100.00%> (ø)
dataclasses_avroschema/schema_generator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17d4b2...56e375f. Read the comment docs.

@marcosschroh marcosschroh merged commit fdccbbd into marcosschroh:master Jun 30, 2021
@marcosschroh
Copy link
Owner

Thanks @pawelrubin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants