-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add int
and float
Avro type support
#119
Conversation
@marcosschroh Thoughts? I think the Are you also happy with this testing? |
INT
and FLOAT
supportINT
and FLOAT
Avro type support
INT
and FLOAT
Avro type supportint
and float
Avro type support
Looks much cooler than my approach, thank you! BTW, you can automate closing related issues by proper pull request description. |
I think @marcosschroh will ask for documentation update |
Huh, didn't actually know that! Thanks!
There is a bit of docs in here. Wasn't really sure what else to add! |
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 99.45% 99.46% +0.01%
==========================================
Files 8 8
Lines 731 749 +18
Branches 111 114 +3
==========================================
+ Hits 727 745 +18
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
Looks really good!! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes made.
Closes #107
Closes #103