Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add int and float Avro type support #119

Merged
merged 11 commits into from
Sep 24, 2021

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Sep 23, 2021

Closes #107
Closes #103

@judahrand
Copy link
Contributor Author

judahrand commented Sep 23, 2021

@marcosschroh Thoughts? I think the typing.Annotated approach makes a lot more sense than the other PR as all we are aiming to use the native type but communicate additional information to the package to Avro serialization + schema generation. Which is exactly what it's for.

Are you also happy with this testing?

@judahrand judahrand changed the title Add INT and FLOAT support feat: add INT and FLOAT Avro type support Sep 23, 2021
@judahrand judahrand changed the title feat: add INT and FLOAT Avro type support feat: add int and float Avro type support Sep 23, 2021
@eugene-bright
Copy link
Contributor

Looks much cooler than my approach, thank you!

BTW, you can automate closing related issues by proper pull request description.

@eugene-bright
Copy link
Contributor

I think @marcosschroh will ask for documentation update

@judahrand
Copy link
Contributor Author

BTW, you can automate closing related issues by proper pull request description.

Huh, didn't actually know that! Thanks!

I think @marcosschroh will ask for documentation update

There is a bit of docs in here. Wasn't really sure what else to add!

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #119 (85eead0) into master (15474b0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   99.45%   99.46%   +0.01%     
==========================================
  Files           8        8              
  Lines         731      749      +18     
  Branches      111      114       +3     
==========================================
+ Hits          727      745      +18     
  Misses          2        2              
  Partials        2        2              
Impacted Files Coverage Δ
dataclasses_avroschema/fields.py 99.55% <100.00%> (+0.01%) ⬆️
dataclasses_avroschema/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15474b0...85eead0. Read the comment docs.

@marcosschroh
Copy link
Owner

Looks really good!! Thanks.

Copy link
Contributor Author

@judahrand judahrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made.

@marcosschroh marcosschroh merged commit 9a1780d into marcosschroh:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add types.Int32
3 participants