-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: new style type annotations don't work for containers and maps #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 9 9
Lines 788 788
Branches 121 121
=======================================
Hits 785 785
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
@marcosschroh That |
Looking good. Shall we add a test for python @pytest.mark.skipif(sys.version_info < (3, 10), reason="requires python3.10 or higher")
def test_function():
# Test containers and maps for 3.10 using dict, list and tuple as types
... |
I'm not sure I understand what you mean? I added Furthermore, this issue isn't a 3.10 issue it's a >=3.9 issue. Hence I mark See my changes in |
Oh, sorry. I missed that you add the types 😔 . SEQUENCE_TYPES = (typing.List, typing.Tuple, typing.Sequence, typing.MutableSequence, list, tuple) # added list and tuple
MAPPING_TYPES = (typing.Dict, typing.Mapping, typing.MutableMapping, dict) # added dict |
Would previously fail