Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for default null decimals #130

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

chapm250
Copy link
Contributor

@chapm250 chapm250 commented Oct 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #130 (a4c92fd) into master (aea206b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   99.61%   99.62%           
=======================================
  Files           9        9           
  Lines         788      792    +4     
  Branches      121      123    +2     
=======================================
+ Hits          785      789    +4     
  Misses          2        2           
  Partials        1        1           
Impacted Files Coverage Δ
dataclasses_avroschema/fields.py 99.55% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea206b...a4c92fd. Read the comment docs.

@marcosschroh
Copy link
Owner

Thanks @chapm250 for the work. We can go with this solution but it is not ideal because it won't work with unions:

class MyAvro(AvroModel):
    an_union: typing.Union[int, types.Decimal]

We need to follow a different approach, like we are trying to do with #108

@marcosschroh marcosschroh merged commit 9c93e18 into marcosschroh:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants