Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pydantic UUID4 when generating pydantic models. #247

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

mhils
Copy link
Contributor

@mhils mhils commented Feb 24, 2023

This PR updates pydantic model generation to use pydantic.UUID4 instead of uuid.uuid4. The latter crashes pydantic. 馃檭 Thank you for the fantastic library!

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #247 (88000df) into master (29bd374) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   99.37%   99.38%           
=======================================
  Files          14       15    +1     
  Lines        1283     1291    +8     
  Branches      264      218   -46     
=======================================
+ Hits         1275     1283    +8     
  Misses          3        3           
  Partials        5        5           
Impacted Files Coverage 螖
...avroschema/model_generator/avro_to_python_utils.py 100.00% <100.00%> (酶)
...taclasses_avroschema/model_generator/base_class.py 100.00% <100.00%> (酶)
...ataclasses_avroschema/model_generator/generator.py 99.10% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marcosschroh
Copy link
Owner

Thanks @mhils It looks good !! :-)

@marcosschroh marcosschroh merged commit 6e317fc into marcosschroh:master Feb 24, 2023
@mhils mhils deleted the pydantic-uuid branch February 25, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants