Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly generate enum default values #275

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

marcosschroh
Copy link
Owner

fix: correctly generate type annotations

fix: do not generate default dataclass docstrings

fix: datetime model generation

the previous implementation did not roundtrip

feat: render docstrings in generated classes

fix: correct union and optional conversion

test: add avsc -> python -> avsc roundtrip test

fix: properly handle aliases in the model generator

tests: add coverage for single-type unions model generation

fix: correctly generate type annotations

fix: do not generate default dataclass docstrings

fix: datetime model generation

the previous implementation did not roundtrip

feat: render docstrings in generated classes

fix: correct union and optional conversion

test: add avsc -> python -> avsc roundtrip test

fix: properly handle aliases in the model generator

tests: add coverage for single-type unions model generation
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-29 11:44 UTC

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #275 (f98b507) into master (855bd7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          15       15           
  Lines        1304     1309    +5     
  Branches      268      266    -2     
=======================================
+ Hits         1297     1302    +5     
- Misses          2        3    +1     
+ Partials        5        4    -1     
Impacted Files Coverage Δ
...avroschema/model_generator/avro_to_python_utils.py 100.00% <ø> (ø)
dataclasses_avroschema/fields.py 99.39% <100.00%> (ø)
...ataclasses_avroschema/model_generator/generator.py 99.11% <100.00%> (+<0.01%) ⬆️
...ataclasses_avroschema/model_generator/templates.py 100.00% <100.00%> (ø)
dataclasses_avroschema/schema_definition.py 98.64% <100.00%> (+0.07%) ⬆️
dataclasses_avroschema/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants