Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model generator when fields have metadata. Closes #348 #355

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

marcosschroh
Copy link
Owner

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://marcosschroh.github.io/dataclasses-avroschema/pr-preview/pr-355/
on branch gh-pages at 2023-06-29 11:53 UTC

@marcosschroh marcosschroh force-pushed the fix/schema-generation-with-field-metadata branch from cfaa9d0 to 3e7ea9a Compare June 29, 2023 11:52
@marcosschroh marcosschroh force-pushed the fix/schema-generation-with-field-metadata branch from 3e7ea9a to d034544 Compare June 29, 2023 11:53
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #355 (d034544) into master (6aa250f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   99.15%   99.17%   +0.02%     
==========================================
  Files          16       16              
  Lines        1297     1334      +37     
  Branches      255      269      +14     
==========================================
+ Hits         1286     1323      +37     
  Misses          3        3              
  Partials        8        8              
Impacted Files Coverage Δ
...ataclasses_avroschema/model_generator/generator.py 99.23% <100.00%> (+0.12%) ⬆️

@marcosschroh marcosschroh merged commit d7cbd36 into master Jun 29, 2023
8 checks passed
@marcosschroh marcosschroh deleted the fix/schema-generation-with-field-metadata branch June 29, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant