Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record fields avro schema creation (#382) #383

Conversation

dada-engineer
Copy link
Contributor

Fixes #382

@dada-engineer
Copy link
Contributor Author

This needs some rework as now it would break union types

@dada-engineer
Copy link
Contributor Author

Changed the solution to something that renders only actual values of the default into the schema. This should work and does not break other existing stuff. 🤞🏻

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #383 (ef14661) into master (18e942e) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          20       20           
  Lines        1487     1490    +3     
  Branches      271      272    +1     
=======================================
+ Hits         1476     1479    +3     
  Misses          3        3           
  Partials        8        8           
Files Changed Coverage Δ
dataclasses_avroschema/fields/fields.py 99.00% <100.00%> (+<0.01%) ⬆️
dataclasses_avroschema/schema_definition.py 98.82% <100.00%> (+0.02%) ⬆️

@marcosschroh marcosschroh merged commit 041617a into marcosschroh:master Aug 15, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordField default_to_avro produces non serializable output
2 participants