Fix schema generation with optional Enum fields #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 20 20
Lines 1487 1487
Branches 271 271
=======================================
Hits 1476 1476
Misses 3 3
Partials 8 8
|
…/dataclasses-avroschema into fix-enum-schema-generation
marcosschroh
added a commit
that referenced
this pull request
Aug 14, 2023
* fix enum schema generation * format code * add default value to dict get * format files * different approach to field comparison --------- Co-authored-by: Marcos Schroh <2828842+marcosschroh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #380 where optional Enum field with default value generates invalid Avro schema.
Root cause was the fact that for enum (and probably others) - field type is either full definition or a reference string (if full definition was already emitted) which was not accounted for when comparing lists of fields internally in this library.