Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: field ordering when field has metadata but not a default value. … #403

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

marcosschroh
Copy link
Owner

Closes #401

@github-actions
Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://marcosschroh.github.io/dataclasses-avroschema/pr-preview/pr-403/
on branch gh-pages at 2023-08-30 14:14 UTC

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #403 (8af3b65) into master (f009f4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          20       20           
  Lines        1497     1498    +1     
  Branches      274      275    +1     
=======================================
+ Hits         1486     1487    +1     
  Misses          3        3           
  Partials        8        8           
Files Changed Coverage Δ
...ataclasses_avroschema/model_generator/generator.py 99.31% <100.00%> (+<0.01%) ⬆️

@marcosschroh marcosschroh merged commit e04b9c9 into master Aug 30, 2023
8 checks passed
@marcosschroh marcosschroh deleted the fix/fields-order-with-dataclasses-field branch August 30, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

field ordering issue causing invalid python models
1 participant