Resolve issues with raw None annotation
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they have type ["null", "null"].
Prometheus3375
changed the title
null fields and resolve issues with not converted None annotationNone annotation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 99.28% 99.29%
=======================================
Files 20 20
Lines 1548 1552 +4
Branches 288 289 +1
=======================================
+ Hits 1537 1541 +4
Misses 3 3
Partials 8 8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #424.
While working on the fix, I noticed some typos and minor issues:
readme.md- To run tests locally, one should runpoetry install --all-extras. Otherwise, tests will fail becausepydanticis not installed.dataclasses_avroschema/fields/mapper.pyandtests/fields/test_primitive_types.py.tests/fields/consts.py- tuplePRIMITIVE_TYPES_AND_DEFAULTShas member withAnnotated[bool, "boolen"].ais missing.Should/may I also fix these problems?