Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install typing-extensions when using Python > 3.8. Closes #540 #541

Conversation

Oskar-Bonde
Copy link
Contributor

This is a fix for the following bug. typing-extensions is now installed when using Python > 3.8

Describe the bug
typing extensions is not a required dependency when using Python > 3.8. So when using Python > 3.8 an import error is raised.

To Reproduce
Install dataclasses-avroschema using Python > 3.8. Make sure no other package is installing typing-extensions. Import error will be raised when trying to use AvroModel because of the following import: from typing_extensions import get_args.

Expected behavior
No import error.

Fix by updating pyproject.toml, remove python version requirement from typing-extensions.

@Oskar-Bonde Oskar-Bonde changed the title Install typing-extensions when using Python > 3.8 fix Install typing-extensions when using Python > 3.8 Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d6ef42) 99.18% compared to head (a7fd2ae) 99.18%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          30       30           
  Lines        1712     1712           
  Branches      307      307           
=======================================
  Hits         1698     1698           
  Misses          6        6           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oskar-Bonde Oskar-Bonde changed the title fix Install typing-extensions when using Python > 3.8 fix: install typing-extensions when using Python > 3.8 Feb 12, 2024
@Oskar-Bonde Oskar-Bonde changed the title fix: install typing-extensions when using Python > 3.8 fix: install typing-extensions when using Python > 3.8 (#540) Feb 12, 2024
@Oskar-Bonde Oskar-Bonde changed the title fix: install typing-extensions when using Python > 3.8 (#540) fix: install typing-extensions when using Python > 3.8. Closes #540 Feb 12, 2024
@marcosschroh marcosschroh merged commit 8e66164 into marcosschroh:master Feb 12, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants