-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for decimal logical type #86
Conversation
Added in types and fields definitions for Decimal. Added in tests for fields. NEED MORE TESTS AT MIN.
…e to match schema, updated tests
Little bit of reorganization of the added functions, added in serialization and schema tests, added in documentation, linted and tested. Off the discussion in Issue 84, this was tweaked to error out on a |
dataclasses_avroschema/fields.py:816: error: Incompatible types in assignment (expression has type "type", variable has type "Type[InmutableField]") dataclasses_avroschema/fields.py:816: note: "type.__call__" has type "Callable[[VarArg(Any), KwArg(Any)], Any]" and couldn't figure out why
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 99.50% 99.55% +0.04%
==========================================
Files 7 7
Lines 608 672 +64
Branches 93 105 +12
==========================================
+ Hits 605 669 +64
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
Looking good @xgamer4 . Just minors comments |
Added in functionality for Decimal logical data types based of Python's decimal.Decimal class, added in fields and types.
Added in types and fields definitions for Decimal. Added in tests for fields and updated documentation. decimal.Decimal types can be declared in two ways: