Minor corrections after cppcheck

marcromani · Apr 6, 2024 · 08e3e32 · 08e3e32
1 parent 767592b
commit 08e3e32
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/node_var.cpp b/src/node_var.cpp
@@ -49,7 +49,7 @@ double NodeVar::covariance(const std::shared_ptr<NodeVar>& x, const std::shared_
     }
 }
 
-void NodeVar::setCovariance(std::shared_ptr<NodeVar>& x, std::shared_ptr<NodeVar>& y, double value)
+void NodeVar::setCovariance(const std::shared_ptr<NodeVar>& x, const std::shared_ptr<NodeVar>& y, double value)
 {
     if (x->id_ < y->id_)
     {

diff --git a/src/node_var.h b/src/node_var.h
@@ -18,7 +18,7 @@ class NodeVar final : public Node
     double sigma() const;
 
     static double covariance(const std::shared_ptr<NodeVar>&, const std::shared_ptr<NodeVar>&);
-    static void setCovariance(std::shared_ptr<NodeVar>&, std::shared_ptr<NodeVar>&, double);
+    static void setCovariance(const std::shared_ptr<NodeVar>&, const std::shared_ptr<NodeVar>&, double);
 
 private:
     std::unordered_map<int, double> covariance_;

diff --git a/src/var.cpp b/src/var.cpp
@@ -279,9 +279,9 @@ double Var::covariance_(const Var &x, const Var &y)
 
     std::vector<double> matrix;
 
-    for (Var row: nodes)
+    for (const Var &row: nodes)
     {
-        for (Var col: nodes)
+        for (const Var &col: nodes)
         {
             // This doesn't end up being a recursive call chain since `nodes` contains leaf variables
             matrix.push_back(covariance(row, col));