allow custom delimiter to be set

[fawaf]

No description provided.

[marcua]

uncomment this, and remove the spaces for the default version

[marcua]

Awesome! Two quick comments

[marcua]

My vote would be to make user-readable errors for both of these issues, and then require the variables to be uncommented. Having two ways to set the default (one is the kwarg and one is the setting) seems like it might otherwise be confusing to the user.

[fawaf]

I agree with you on the first part, but I am not sure what you mean by the second part. The user is not setting it two ways. The kwarg is in the code, meaning the user cannot modify it (as if it is a C/Java program). The setting is the one that is modifiable, but, in my opinion, does not have to be set. Which is why if the delimiter is commented out in the settings file, the code should still work, meaning it would default to what is set in the code.

[marcua]

The type signature of the function has delimiter = u"|", which would make a developer think that if they don't pass the delimiter kwarg in, the value will be u"|". This would be a wrong assumption if the DELIMITER setting is set. If you prefer to go the route of adding a setting for it, then

1. remove the delimiter kwarg
2. make a user-readable error if settings.DELIMITER is missing
3. make the default settings.DELIMITER have no spaces, just a single pipe

Sound good?

[fawaf]

I like that better, but does that mean there will be no default for the delimiter? i.e. just error if you do not have DELIMITER set in the config file? I usually think that a sane default, when it makes sense (which I think it does), is better than a user-readable error. Though i do agree that the signature should not have delimiter argument.

[marcua]

It's fine to have a default. If you agree, the steps would be:

• Make settings.DELIMITER = u"|"
• Delete the delimiter argument.
• If settings.DELIMITER isn't set, set the delimiter to u"|"

[fawaf]

updated to reflect this change.
also please close issue #3 since it was already fixed by @Oshini.

[marcua]

This looks great. Thanks @gnowxilef!