-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems of promotions #13
Conversation
Can you comment in this comment section about how to duplicate the problem and how to fix it? |
An error is raised when a Pawn can take another piece in the last line ( line 8 for whites, 1 for blacks ) because it have to be promoted in the same time. |
For instance :
|
@mathjudo I attempted the same change db9d95b you made, but it doesn't work (White pawn on a7)?
|
Did you also modified the Pawn.py file as I sent ? |
Thanks, I missed that line 74. I modified |
@mathjudo Please try latest |
Coming in just over a year late on this one! This diff looks odd though, @mathjudo should this go in or no? I haven't really been paying much attention to this project, as you can tell |
Closed for the following reasons:
If anyone still has problems with this, please leave a comment so the community can discuss about it. |
Hello everyone,
There were some problems of promotion when pawns had to be promoted when they took.
Sorry I don't find how to open correctly a pull request (with correct comparaisons) so I jus put modified files here. Changes are in methods undoLastMove and makeMove of Board and in line 74 of Pawn
Have a nice day