Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to re-edit on confirmation step #17

Closed
bew opened this issue Feb 13, 2021 · 2 comments
Closed

Allow to re-edit on confirmation step #17

bew opened this issue Feb 13, 2021 · 2 comments

Comments

@bew
Copy link
Contributor

bew commented Feb 13, 2021

Imagine you make some changes, and at the confirmation step you realise you made a mistake.

It would be nice to be able to add more actions than yes/no like:

  • edit (re-open the tmp file to continue edit)
  • restart/reset (discard the tmp file and make a new one)

What do you think of this?
@bew bew mentioned this issue Feb 13, 2021
Closed
@marcusbuffett
Copy link
Owner

I think this is a great idea, would definitely accept a PR w/ this, or I can get around to it at one point

mtimkovich added a commit to mtimkovich/pipe-rename that referenced this issue Apr 27, 2021
@mtimkovich
Refactor main into functions.
8f70108 
I wanted to work on marcusbuffett#17, but that requires reusing parts of the code
which wasn't possible with the existing implementation. This also
reduces the scope of some variables and makes it easier to read.
@mtimkovich mtimkovich mentioned this issue Apr 27, 2021
Merged
mtimkovich added a commit to mtimkovich/pipe-rename that referenced this issue Apr 27, 2021
@mtimkovich
Add 'edit' and 'reset' options. (marcusbuffett#17)
a3dbdc4 
After exiting the editor, adds 2 additional options:
- `Edit` reopens the editor with user changes.
- `Reset` reopens the editor with the initial filelist.
mtimkovich added a commit to mtimkovich/pipe-rename that referenced this issue Apr 27, 2021
@mtimkovich
Add 'edit' and 'reset' options. (marcusbuffett#17)
8eea535 
After exiting the editor, adds 2 additional options:
- `Edit` reopens the editor with user changes.
- `Reset` reopens the editor with the initial filelist.

Moved tempfile creation inside `open_editor` because MacOS was *not*
happy with me trying to reopen a closed tempfile.
mtimkovich added a commit to mtimkovich/pipe-rename that referenced this issue Apr 27, 2021
@mtimkovich
Add 'edit' and 'reset' options. (marcusbuffett#17)
12e0e70 
After exiting the editor, adds 2 additional options:
- `Edit` reopens the editor with user changes.
- `Reset` reopens the editor with the initial filelist.

Moved tempfile creation inside `open_editor` because MacOS was *not*
happy with me trying to reopen a closed tempfile.
marcusbuffett added a commit that referenced this issue Apr 28, 2021
@marcusbuffett
Merge pull request #23 from mtimkovich/edit-reset
ffec2d3 
Add `edit` and `reset` options. (#17)
@bew
Copy link
Contributor Author

bew commented Apr 29, 2021 •
edited

I guess this can be closed now, thanks @mtimkovich for the impl!
I wanted to do it as well but was virtually block by the method to use to select from multiple choices.. 👍
Will have to test this (;

@bew bew closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcusbuffett @bew