Undefined Offset on line 284 in question.php

[dustinbrisebois]

Notice: Undefined offset: 26 in /var/www/data/pvschools/public_html/moodle/question/type/wordselect/question.php on line 286
Exception - Call to a member function get_without_delim() on null

As per line:

moodle-qtype_wordselect/question.php

Line 284 in 37f509b

$summary .= " " . $allwords[substr($index, 1)]->get_without_delim() . " ";

Should be something more similar to this:

if (isset($allwords[substr($index, 1)])) {
          $summary .= " " . $allwords[substr($index, 1)]->get_without_delim() . " ";
} else {
          return '';
}

Where the assumption that the item exists in the array - if it doesn't it faults out.

[marcusgreen]

Thanks Dustin, Can you tell me how to reproduce this so that when I update the code I can include an automated test for it?

[marcusgreen]

would you email me at marcusgreen at mailbox.org

[dustinbrisebois]

@marcusgreen were you able to sort this out?

[marcusgreen]

Hi Dustin
I was never able to reproduce this but I have just done a commit which I think is a slightly more concise version of your suggestion just in case. Please correct me if you think it doesn't do what you expect.
daf2e64
I am currently working on a branch that will support the mobile app so this will get pushed to the plugins database as part of that release.