Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nerdctl #132

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Support nerdctl #132

merged 2 commits into from
Aug 24, 2023

Conversation

giabao
Copy link
Contributor

@giabao giabao commented Jun 6, 2023

  • Fix "unknown flag: --pull" when run with nerdctl
    Reason: nerdctl don't support --pull option
    Changes: If buildOptions.pullBaseImage == Pull.IfMissing (default) then we omit this flag
  • Fix the imageId extracting logic from build log when run with nertctl

Reason: nerdctl (https://github.com/containerd/nerdctl) don't support --pull option
Changes: If buildOptions.pullBaseImage == Pull.IfMissing (default) then we omit this flag
@giabao giabao changed the title Fix "unknown flag: --pull" when run with nerdctl Support nerdctl Jun 6, 2023
@marcuslonnberg marcuslonnberg merged commit eedbd60 into marcuslonnberg:master Aug 24, 2023
@marcuslonnberg
Copy link
Owner

Great, thanks! 👍
Released in version 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants