Append suffix to param key to uniquify duplicate param keys #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
This PR is my attempt to address issue 169.
Apologies in advance if this proposed fix is too naive - It's been awhile since I've done any JS coding. The fix simply appends a suffix to the param name (key) for each param before adding it to the
paramsData
map. It then strips the suffix off before constructing the request URL in_request()
. I tested this change by loading the plugin in a local grafana instance and modifying an existing dashboard we have for viewing Prometheus alerts - which uses this plugin - to make API calls to Alertmanager. I then repeatedly added/removed various combinations of request parameters (including params with duplicate keys) via the Grafana UI and then verified in each case that the final constructed URL string looked as expected by intercepting the requests using a simple proxy that was placed in front of Alertmamager which would dump the request URL before forwarding the request.I also ran the unit tests in the repo (output captured below):