Allow super_fn argument passing from mixins #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mixin calls
super_fn
, the arguments are currently bound to the original call, which makes it impossible to do some more advanced things, like overrideset
for example.As a plugin author, you may expect that calling
set('foo', 'bar')
results inMODIFIEDbar
being stored. But because the original args value,bar
, is bound, that's the value that gets stored.With this PR, any arguments passed into
super_fn
override the original values, so callingset('foo', 'bar')
with this PR results inMODIFIEDbar
being stored.Additionally, any additional arguments passed in the original call will continue to be passed through unmodified.
I'm not entirely sure how to write tests for this change, short of writing a plugin that would use this change. That said, I would like to modify #204 to use it...