Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed '*/' bug in build.js #34

Merged
merged 1 commit into from
Jan 18, 2012
Merged

fixed '*/' bug in build.js #34

merged 1 commit into from
Jan 18, 2012

Conversation

manuelvanrijn
Copy link
Contributor

Changed the /* to */ so the build makes correct minified files

@marcuswestin
Copy link
Owner

Ay - that's bad! I could have sworn I tested the build, but I must have gotten the wrong one... Thanks for fixing it!

Cheers,
Marcus

-- while mobile

On Jan 18, 2012, at 6:37 AM, Manuel van Rijnreply@reply.github.com wrote:

Changed the /* to */ so the build makes correct minified files

You can merge this Pull Request by running:

git pull https://github.com/manuelvanrijn/store.js build-fix

Or you can view, comment on it, or merge it online at:

#34

-- Commit Summary --

  • fixed '*/' bug in build.js

-- File Changes --

M build.js (2)
M store+json2.min.js (2)
M store.min.js (2)

-- Patch Links --

https://github.com/marcuswestin/store.js/pull/34.patch
https://github.com/marcuswestin/store.js/pull/34.diff


Reply to this email directly or view it on GitHub:
#34

@manuelvanrijn
Copy link
Contributor Author

No problem!

Cheers,
Manuel

Op 18 jan. 2012 om 16:05 heeft Marcus Westin
reply@reply.github.com
het volgende geschreven:

Ay - that's bad! I could have sworn I tested the build, but I must have gotten the wrong one... Thanks for fixing it!

Cheers,
Marcus

-- while mobile

On Jan 18, 2012, at 6:37 AM, Manuel van Rijnreply@reply.github.com wrote:

Changed the /* to */ so the build makes correct minified files

You can merge this Pull Request by running:

git pull https://github.com/manuelvanrijn/store.js build-fix

Or you can view, comment on it, or merge it online at:

#34

-- Commit Summary --

  • fixed '*/' bug in build.js

-- File Changes --

M build.js (2)
M store+json2.min.js (2)
M store.min.js (2)

-- Patch Links --

https://github.com/marcuswestin/store.js/pull/34.patch
https://github.com/marcuswestin/store.js/pull/34.diff


Reply to this email directly or view it on GitHub:
#34


Reply to this email directly or view it on GitHub:
#34 (comment)

marcuswestin added a commit that referenced this pull request Jan 18, 2012
@marcuswestin marcuswestin merged commit 106d28c into marcuswestin:master Jan 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants