Merge pull request #87 from marcwittke/hotfix/5.1.17

no commit of unit of work on exception during mvc call
marcwittke · Nov 4, 2019 · d4a91ca · d4a91ca
2 parents a5e4f3e + e2a1269
commit d4a91ca
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/environments/Backend.Fx.AspNetCore.Mvc/UnitOfWork/UnitOfWorkFilter.cs b/src/environments/Backend.Fx.AspNetCore.Mvc/UnitOfWork/UnitOfWorkFilter.cs
@@ -1,11 +1,13 @@
-using Backend.Fx.Patterns.DependencyInjection;
+using Backend.Fx.Logging;
+using Backend.Fx.Patterns.DependencyInjection;
 using Backend.Fx.Patterns.UnitOfWork;
 using Microsoft.AspNetCore.Mvc.Filters;
 
 namespace Backend.Fx.AspNetCore.Mvc.UnitOfWork
 {
     public class UnitOfWorkFilter : IActionFilter
     {
+        private static readonly ILogger Logger = LogManager.Create<UnitOfWorkFilter>();
         private readonly IBackendFxApplication _application;
 
         public UnitOfWorkFilter(IBackendFxApplication application)
@@ -29,7 +31,14 @@ public void OnActionExecuted(ActionExecutedContext context)
 
             try
             {
-                unitOfWork.Complete();
+                if (context.Exception == null)
+                {
+                    unitOfWork.Complete();
+                }
+                else
+                {
+                    Logger.Warn($"Preventing unit of work completion due to {context.Exception.GetType().Name}: {context.Exception.Message}");
+                }
             }
             finally
             {