Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IbanCheckDigit#validate return false instead of raising an exception for null or less than 5 characters strings #188

Closed
marcwrobel opened this issue Sep 7, 2022 · 1 comment · Fixed by #216
Closed

Make IbanCheckDigit#validate return false instead of raising an exception for null or less than 5 characters strings #188

marcwrobel opened this issue Sep 7, 2022 · 1 comment · Fixed by #216
Labels
enhancement
Milestone
4.0.0

Comments

@marcwrobel
Copy link
Owner

Currently IbanCheckDigit#validate raise an exception for null or less than 5 characters strings.

Should this method return false instead ?
@marcwrobel marcwrobel added this to the 4.0.0 milestone Sep 7, 2022
@marcwrobel
Copy link
Owner Author

This issue relates to #183.

marcwrobel added a commit that referenced this issue Oct 15, 2022
@marcwrobel
Make IbanCheckDigit#validate return false for all invalid strings (…
b27a8dd 
…closes #188)

It does not make sense to raise an exception in a validation method that returns a boolean.
@marcwrobel marcwrobel linked a pull request Oct 15, 2022 that will close this issue
Make IbanCheckDigit#validate return false for all invalid strings #216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Make IbanCheckDigit#validate return false for all invalid strings marcwrobel/jbanking
1 participant
@marcwrobel