Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

Fails to distribute already mirrored packages with _ or - #21

Closed
EvaSDK opened this issue Nov 13, 2013 · 3 comments
Closed

Fails to distribute already mirrored packages with _ or - #21

EvaSDK opened this issue Nov 13, 2013 · 3 comments

Comments

@EvaSDK
Copy link
Contributor

EvaSDK commented Nov 13, 2013

Some packages like riak_pb or factory_boy use an _ in their name but their name is converted to using - using bdist_wheel. Not sure if this is a bug with wheel or not but this brought my attention to a "fix" to handle this case that has been added to pypiserver.

When requesting a package name like factory-boy, pypiserver will answer a redirect to the correct package name which is factory_boy.

This issue is a bit different than the one reported in #10 because that issue was about mirroring the package and this one is about serving the package to the client.

This seems to be no issue for regular pip or easy_install, but it fails for pip --use-wheel.

EvaSDK added a commit to EvaSDK/pyshop that referenced this issue Nov 13, 2013
Some packages like factory_boy or riak_pb are transformed by wheel to
factory-boy and riak-pb. pypiserver handles that with a redirection to
the real name but simply serving the right package directly works as
well (at least for pip --use-wheel).
@EvaSDK
Copy link
Contributor Author

EvaSDK commented Nov 13, 2013

I guess the logic should also work for _ to - but I only handled the first case to match the current mirror behavior.

mardiros added a commit that referenced this issue Nov 13, 2013
mardiros added a commit that referenced this issue Nov 13, 2013
@EvaSDK
Copy link
Contributor Author

EvaSDK commented Dec 13, 2013

I finally had time to update pyshop running at work and it is doing fine with this patch. Thanks.

@mardiros
Copy link
Owner

Ok, thanks for the feedback

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants