Use Symfony's security system #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marein
force-pushed
the
153-use-symfonys-security-system
branch
from
cb0a9db
to
2713289
Compare
Upon arrival, ArrivialAuthenticator creates a new user in the identity context and authenticates them in the session. The current implementation covers what AssignUserIdOnKernelRequest did before. It adds some complexity, but opens the way for #130 to secure the /metrics endpoint with basic auth, and #6 to eventually authenticate the user in any way.
marein
force-pushed
the
153-use-symfonys-security-system
branch
from
2713289
to
de5e85a
Compare
marein
commented
Oct 16, 2022
marein
force-pushed
the
153-use-symfonys-security-system
branch
from
42ea481
to
b51904c
Compare
This reverts commit b51904c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon arrival,
ArrivialAuthenticatorcreates a new user in the identity context and authenticates them in the session.The current implementation covers what
AssignUserIdOnKernelRequestdid before. It adds some complexity, but opens the way for #130 to secure the/metricsendpoint for php with basic auth, and #6 to eventually authenticate the user in any way.