Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example command #4

Closed
iimog opened this issue Aug 14, 2019 · 1 comment
Closed

Example command #4

iimog opened this issue Aug 14, 2019 · 1 comment

Comments

@iimog
Copy link

iimog commented Aug 14, 2019

As part of my JOSS review I ran the example command and I have some comments:

  1. Installing spruceup through pip does not copy the examples directory to the users computer. So it would help to let the users know that in order to try the example they have to download the tar.gz or clone the repo (or at least download the files in examples from GitHub).
  2. Running the example command exactly as stated in the README (from the spruceup directory not the examples directory) results in:
    Sorry, could not read input alignment file "test_aln_nt.fasta": No such file or directory
    Running the command from the examples directory works.
  3. The example config does not work for single core machines. Running on a single core machine results in:
    You specified more (2) compute cores than are available (1). Exiting.
    I don't think this is a big problem as changing the setting to 1 is straightforward. However, 1 core is enough for this demo so you might as well change this setting to 1 by default in the demo to avoid this issue.
@iimog iimog mentioned this issue Aug 19, 2019
@marekborowiec
Copy link
Owner

These should now be resolved through 1. README instructions that specifically refer to example files when downloaded from source repo, 2. added explanation that the user must be running spruceup in the same directory as the alignment and config file or, alternatively, provide absolute paths in config and 3. default is now one core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants