Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement uniform card heights #38

Closed
audreyfeldroy opened this issue Aug 15, 2021 · 7 comments
Closed

Implement uniform card heights #38

audreyfeldroy opened this issue Aug 15, 2021 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@audreyfeldroy
Copy link
Member

audreyfeldroy commented Aug 15, 2021

The problem has been described well by @GrungeKarma in #33:

I am seeing an issue as this project moves forward. I am thinking we need to standardize the card size on a component level. As it sits, when I try to adjust the layout of the cards it looks bad because of the different card heights due to the different lengths of text in each card. It may be better to control the size of the cards directly so we can predict how they will act with flexbox. It would probably be easy to add a description length for each explanation and include a button for more information that brings up the expanded explanation as a popup or a separate page. Let me know if you have any ideas as well. Those are just the ideas going through my head.

Any solution that addresses this would be great, such as:

  • Add a description length for each explanation and include a button for more information that brings up the expanded explanation as a popup or a separate page.
  • Break up card description into short description and long description, where long description is shown only when you click "more" or similar
  • Truncate text after a certain length with "..."
  • Manually shorten the text of each card

Don't stress over getting this perfectly right: we can always iterate.

@audreyfeldroy audreyfeldroy added help wanted Extra attention is needed high priority Help urgently needed and your PR will be reviewed extra quickly good first issue Good for newcomers labels Aug 15, 2021
@audreyfeldroy audreyfeldroy removed the high priority Help urgently needed and your PR will be reviewed extra quickly label Aug 16, 2021
@audreyfeldroy
Copy link
Member Author

We don't necessarily have to implement this. See #33 for more info about masonry as an alternative multi-column layout for varying card heights.

@GrungeKarma
Copy link
Contributor

The cards are now housed in divs with predefined widths making them more standard. If we decided to go down the road of uniformity we will also have to implement a standard height and do some textual content editing.

@audreyfeldroy
Copy link
Member Author

That PR was such a huge help @GrungeKarma. Agreed about your points about choosing a standard height and content editing.

I'd love to hear everyone's thoughts about uniform card heights vs. masonry vs. other approaches.

Also, I'm totally open to PRs with better writing or copy-editing as a means of partially or fully improving how the cards look.

@GrungeKarma
Copy link
Contributor

I am going to take a look at this one as well.

@RedFox0x20
Copy link
Collaborator

I believe this is no-longer an issue due to #72

@audreyfeldroy
Copy link
Member Author

Yep, thanks for posting that comment @RedFox0x20, helps me keep track. I know there's a way to auto-resolve issues from a PR merge. I suppose we should look into that at some point.

And thank you again @GrungeKarma for all your contributions. I know you're still new to much of this. I just wanted to say you're doing great. An open-source repo with this much activity is not easy to contribute to, especially while you're learning. Keep up the good work!

@GrungeKarma
Copy link
Contributor

No problem, I am happy to help and this is a great learning experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants