-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement uniform card heights #38
Comments
We don't necessarily have to implement this. See #33 for more info about masonry as an alternative multi-column layout for varying card heights. |
The cards are now housed in divs with predefined widths making them more standard. If we decided to go down the road of uniformity we will also have to implement a standard height and do some textual content editing. |
That PR was such a huge help @GrungeKarma. Agreed about your points about choosing a standard height and content editing. I'd love to hear everyone's thoughts about uniform card heights vs. masonry vs. other approaches. Also, I'm totally open to PRs with better writing or copy-editing as a means of partially or fully improving how the cards look. |
I am going to take a look at this one as well. |
I believe this is no-longer an issue due to #72 |
Yep, thanks for posting that comment @RedFox0x20, helps me keep track. I know there's a way to auto-resolve issues from a PR merge. I suppose we should look into that at some point. And thank you again @GrungeKarma for all your contributions. I know you're still new to much of this. I just wanted to say you're doing great. An open-source repo with this much activity is not easy to contribute to, especially while you're learning. Keep up the good work! |
No problem, I am happy to help and this is a great learning experience. |
The problem has been described well by @GrungeKarma in #33:
Any solution that addresses this would be great, such as:
Don't stress over getting this perfectly right: we can always iterate.
The text was updated successfully, but these errors were encountered: